update: analyticdb+postgresql vectore #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please run |
chickenlj
reviewed
Oct 28, 2024
|
|
||
| private RedisClientService redisClientService ; | ||
|
|
||
| public static AnalyticdbVector getInstance(String collectionName, AnalyticdbConfig config) throws Exception { |
There was a problem hiding this comment.
Is it possible to declare AnalyticdbVector as a spring bean?
| }catch(Exception e){ | ||
| logger.debug("create Analyticdb client error", e); | ||
| } | ||
| initialize(); |
There was a problem hiding this comment.
Some initialization can be moved to afterPropertiesSet method.
| * @author HeYQ | ||
| * @version 1.0 | ||
| * @ date 2024-10-23 20:29 | ||
| * @ describe |
There was a problem hiding this comment.
Please use @since instead. Delete @ describe if there's no actual description
chickenlj
reviewed
Oct 28, 2024
| } | ||
| } | ||
|
|
||
| public void create(List<Document> texts, List<List<Double>> embeddings) throws Exception { |
There was a problem hiding this comment.
This method is unnecessary, we should follow the interface pattern defined in VectoreStore by spring-ai.
|
pull once again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
add analyticdb api
Describe how to verify it
use springboot test
Special notes for reviews